Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move TransformResult to types package #9747

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 2, 2020

Summary

@jest/test-result is used in a bunch of places, and its dependency on @jest/transform led to everybody depending on babel, istanbul etc.

image

We might wanna do this in more places. It's essentially why Config is still in @jest/types - so modules can depend on the type without pulling in the huge jest-config. As longs as we still re-export the type from the specific package (like @jest/transform does in this case) so you don't need to care about it, I think this is a cleaner solution.

Should move @jest/test-result as well, so jest-message-util doesn't need it

Test plan

Green CI

@SimenB SimenB merged commit f11c366 into jestjs:master Apr 2, 2020
@SimenB SimenB deleted the move-transform-type branch April 2, 2020 08:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants