Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: target node 8.3, not 8.0 #9827

Merged
merged 3 commits into from
Apr 16, 2020
Merged

chore: target node 8.3, not 8.0 #9827

merged 3 commits into from
Apr 16, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 16, 2020

Summary

This drops the objectSpread babel helper, resulting in these sorts of diffs:

image

image

Should in theory be faster on newer nodes as well, as the engine can optimize it

Test plan

Green CI

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit cab4c1d into jestjs:master Apr 16, 2020
@SimenB SimenB deleted the target-node-8 branch April 16, 2020 14:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants