Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default to node test env rather than browser #9874

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 23, 2020

Summary

Fixes #5815.

Test plan

🤷

@SimenB SimenB added this to the Jest 26 milestone Apr 23, 2020
@thymikee
Copy link
Collaborator

We need to make sure this is properly announced and have tools like CRA be informed.

@SimenB
Copy link
Member Author

SimenB commented Apr 23, 2020

Error message thing worked 😀

image

@SimenB SimenB force-pushed the default-node-test-env branch 3 times, most recently from 402f7f3 to b7df539 Compare April 23, 2020 19:51
@cpojer
Copy link
Member

cpojer commented May 2, 2020

Let's do this in 27, it's a big deal and needs to be communicated.

@nickserv
Copy link
Contributor

nickserv commented Jun 25, 2020

Could we put configuration advice including "testEnvironment": "jsdom" directly in the error? In my experience users tend to get confused and not click links if the error doesn't say exactly what to do.

@SimenB
Copy link
Member Author

SimenB commented Jun 25, 2020

Sure! You up for a PR?

@nickserv
Copy link
Contributor

nickserv commented Jul 1, 2020

How is the error being created? I don't think I'm seeing it in this PR.

@SimenB
Copy link
Member Author

SimenB commented Jul 1, 2020

The error message was added in #8245

@SimenB SimenB merged commit 30b6cee into jestjs:master Nov 4, 2020
@SimenB SimenB deleted the default-node-test-env branch November 4, 2020 16:47
jeysal added a commit to mmkal/jest that referenced this pull request Nov 8, 2020
* master: (398 commits)
  chore(breaking): remove undocumented `enabledTestsMap` config (jestjs#10787)
  Change expect.not.objectContaining() to match documentation (jestjs#10708)
  chore: add name to root project (jestjs#10782)
  Added explanation on how to use custom @jest-environment to docs (jestjs#10783)
  fix: remove deprecated functions from the jest object (jestjs#9853)
  chore: convert jest-runtime to ESM (jestjs#10325)
  fix(resolve): use escalade to find package.json (jestjs#10781)
  feat(jest-runner): set exit code to 1 if test logs after teardown (jestjs#10728)
  chore: add `exports` field to all `package.json`s (jestjs#9921)
  fix: do not inject `global` variable into module wrapper (jestjs#10644)
  chore: migrate jest-resolve to ESM (jestjs#10688)
  chore(transform): refactor API to pass an options bag around rather than multiple boolean options (jestjs#10753)
  chore: default to node test env rather than browser (jestjs#9874)
  fix: drop support for node 13 (jestjs#10685)
  chore: show enhanced syntax error for all syntax errors (jestjs#10749)
  chore: update lockfile after publish
  v26.6.3
  chore: update changelog for release
  Don't throw an error if mock dependency can't be found (jestjs#10779)
  chore: bump babel core types (jestjs#10772)
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider disabling JSDOM by default
6 participants