Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vary ESM cache by query #9914

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 29, 2020

Summary

Fixes first part of #9430 (comment)

Test plan

Test added

@codecov-io
Copy link

Codecov Report

Merging #9914 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9914      +/-   ##
==========================================
- Coverage   64.24%   64.23%   -0.02%     
==========================================
  Files         292      292              
  Lines       12464    12466       +2     
  Branches     3076     3075       -1     
==========================================
  Hits         8007     8007              
- Misses       3808     3810       +2     
  Partials      649      649              
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 57.93% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d0b08...d396f68. Read the comment docs.

@SimenB SimenB merged commit fdca483 into jestjs:master Apr 29, 2020
@SimenB SimenB deleted the vary-esm-cache-query branch April 29, 2020 09:23
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants