Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for browser field in config #9943

Merged
merged 2 commits into from
May 2, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 1, 2020

Summary

This allows us to remove the dependency on browser-resolve. As the added deprecation message states, people can specify it as resolver if they want to use it.

Should make sure to specify the upgrade path in the blog post when we release Jest 26.

Test plan

Green CI? 😀 This removes a feature, so not much to test.

@SimenB SimenB added this to the Jest 26 milestone May 1, 2020
@SimenB SimenB requested review from cpojer, thymikee and jeysal May 1, 2020 18:28
@SimenB SimenB force-pushed the remove-browser-field branch 2 times, most recently from 3775116 to d992628 Compare May 1, 2020 18:34
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/jest-config/src/Deprecated.ts Outdated Show resolved Hide resolved
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #9943 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9943   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files         292      292           
  Lines       12466    12466           
  Branches     3075     3076    +1     
=======================================
  Hits         8007     8007           
- Misses       3810     3811    +1     
+ Partials      649      648    -1     
Impacted Files Coverage Δ
packages/jest-config/src/Defaults.ts 100.00% <ø> (ø)
packages/jest-config/src/Deprecated.ts 57.14% <0.00%> (-9.53%) ⬇️
packages/jest-config/src/Descriptions.ts 100.00% <ø> (ø)
packages/jest-config/src/ValidConfig.ts 100.00% <ø> (ø)
packages/jest-config/src/index.ts 11.59% <ø> (ø)
packages/jest-config/src/normalize.ts 76.66% <ø> (ø)
packages/jest-resolve/src/index.ts 44.78% <ø> (ø)
packages/jest-runtime/src/index.ts 57.93% <ø> (ø)
packages/jest-resolve/src/defaultResolver.ts 77.50% <100.00%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b6905...8197d14. Read the comment docs.

@@ -12731,11 +12717,6 @@ resolve-url@^0.2.1:
resolved "https://registry.yarnpkg.com/resolve-url/-/resolve-url-0.2.1.tgz#2c637fe77c893afd2a663fe21aa9080068e2052a"
integrity sha1-LGN/53yJOv0qZj/iGqkIAGjiBSo=

resolve@1.1.7:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss!

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

@cpojer cpojer merged commit e19adcb into jestjs:master May 2, 2020
@SimenB SimenB deleted the remove-browser-field branch May 2, 2020 08:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants