renameTo doesn't rename annotations in type parameters

[steveluscher]

I expected this to rename the type annotation in the type parameter, but it didn't.

/**
 * const A = require('ModuleA');
 * 
 * class Foo<A> {
 *  render(foo: A): A {
 *    return A;
 *   }
 * }
 */
export default function transformer(file, api) {
  const j = api.jscodeshift;
  return j(file.source)
    .find(j.VariableDeclarator, {id: {name: 'A'}})
    .forEach(path => { j(path).renameTo('B'); })
    .toSource();
}

Repro: http://astexplorer.net/#/gist/02d7f52e10dd9c7d803f433635931369/abc53a869b55bc61aa1ded6062d166d655b7c2cc

[steveluscher]

This is because a TypeParameter is not an Identifier. #goodfirstbug

jscodeshift/src/collections/VariableDeclarator.js

Line 87 in e4fdb02

.find(types.Identifier, {name: oldName})

[bgw]

In case anyone runs into this, it's actually because TypeParameter wasn't being traversed. It does have an Identifier child. It's fixed by benjamn/ast-types#253, so #239 (a version bump) should fix this in jscodeshift.