Add support for Flow's IndexedAccessType

[pascalduez]

Currently jscodeshit@0.13.1 choke on Flow's indexed access types.

Error: did not recognize object of type "IndexedAccessType"

It should be "just" a matter of updating recast, which comes with ast-types.
Support for IndexedAccessType was added as of ast-types@0.15.0.

EDIT: as of today, both recast@0.21 and ast-types@0.15 are not published on the latest tag, but next.

/cc @benjamn

[pascalduez]

Thanks @gkz for the update on master.

I tried with this jscodeshift version (git), and the IndexedAccessType errors are gone.

But now it's choking on:
did not recognize object of type "QualifiedTypeofIdentifier"
did not recognize object of type "PropertyDefinition"
Which is weird since they are not new type syntax.
🤷‍♀️

[gkz]

Thanks for the report. When people make changes to our AST output, sometimes ast-types is not updated as well.

If you want you can use yarn resolutions to resolve ast-types to @gkz/ast-types. We are currently using this in combination with flow-parser 0.152 for jscodeshift and it works for us. The ast-types package is very slowly updated unfortunately.

[pascalduez]

For reference to other potential FLow users:

Yarn

"resolutions": {
    "**/ast-types": "npm:@gkz/ast-types",
    "**/flow-parser": "0.152"
  }

Npm

"overrides": {
    "ast-types": "npm:@gkz/ast-types",
    "flow-parser": "0.152"
},

Downside, yarn link doesn't works for CLIs...

[gkz]

Actual ast-types package now includes support for IndexedAccessTypes

[pascalduez]

I tried removing the overrides and all the errors are back. So I guess the whole chain transitive is not up to date or fixed yet.

[seansfkelley]

Apologies for the tangent on a closed issue, but this is currently the highest relevant search result for QualifiedTypeofIdentifier and PropertyDefinition errors. If you encounter those, you can install the ast-types fork defining PropertyDefinition from benjamn/ast-types#727. (There's no PR I see for QualifiedTypeofIdentifier, and I don't actually know or care what these node types look like so I haven't offered my hacky fork as a PR.)