Bug: FloatingTextFormat Toolbar ignores half of my clicks

[AlessioGr]

Google.Chrome.2023-03-20.at.01.53.06.mp4

This video showcases everything (my recording software shows the clicks). Can easily be reproduced in Google Chrome on the lexical playground (at the time of writing, lexical v0.9.0).

As you can see, a lot of times I click on the toolbar, and nothing happens. Anyone should be able to reproduce it by clicking on the floating toolbar more often

[acywatson]

Weird - I can't seem to repro this. Any special set up you're doing before hand? Can you consistently repro it on a fresh page load?

[AlessioGr]

Weird - I can't seem to repro this. Any special set up you're doing before hand? Can you consistently repro it on a fresh page load?

Yep, I can! Although, it is weird and happens very inconsistently. Sometimes more, sometimes less. But I can always get it to happen in the first place.

Here is a complete video from the moment I open the browser, to show that I'm not doing anything special

Arc.2023-03-20.at.02.17.37.mp4

Since it's a bit random, sometimes you need to click different buttons more often than other times for this to occur. Especially towards the end of the video, you can see bugged clicks happening more often, although there are some at the beginning of the video as well.

[HarrySIV]

It's possible it's Mac specific (using their webkit). I also could not reproduce the bug on windows using chrome, but on my iPhone I was having a similar issue, though not as pronounced. I will also add that my phone may be a bit slow updating the changes as they occur, unfortunately I don't have a mac or iPad to test it on.

[maxhelsel]

@AlessioGr @acywatson I've noticed that behavior with clicking toolbars buttons as well - the issue is the mouse listeners introduced in #4013

After removing those lines, my editor fires the button onClick reliably. Those mouse listeners and styles are interfering with the click event, requiring a perfect click without any mouse movement

[AlessioGr]

@maxhelsel I think that's because the
popupCharStylesEditorRef.current.style.pointerEvents = 'none';
gets triggered for normal clicks as well if the mouse is moved during it.

Looking into fixing this right now!

[AlessioGr]

Oh NVM, seems this was fixed by #4298 already!