Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Babel to better support TypeScript #192

Closed
LinusU opened this issue Jul 7, 2018 · 6 comments
Closed

Bumping Babel to better support TypeScript #192

LinusU opened this issue Jul 7, 2018 · 6 comments

Comments

@LinusU
Copy link
Contributor

LinusU commented Jul 7, 2018

Do you want to request a feature or report a bug? feature

What is the current behavior?

Metro, and by extension React Native, ships with Babel 7.0.0-beta.47.

What is the expected behavior?

I would love for Babel to be bumped to at least version 7.0.0-beta.48 to get some much-needed fixes for TypeScript. My end goal is to be able to use Babel to transpile my TypeScript files in my React Native project.

Currently, this doesn't seem possible since the Flow plugin is required to be loaded by React Native, and the TypeScript plugin cannot be active at the same time as Flow. In beta.48 the TypeScript preset was updated to only run on .ts and .tsx files and I think that that would solve the problem of both being loaded.

I tried starting the work on this myself but ran into unexpected trouble and I'm at a loss for how to troubleshoot it. For some reason the basic_bundle-test is running into a "RangeError: Maximum call stack size exceeded" error, after bumping all babel dependencies from beta.47 to beta.48.

Would love some help on continuing this ☺️

@rafeca
Copy link
Contributor

rafeca commented Jul 12, 2018

cc/ @pvdz

@pvdz
Copy link

pvdz commented Jul 12, 2018

Actually @rubennorte is doing this right now :)

@Titozzz
Copy link

Titozzz commented Jul 20, 2018

fixes facebook/react-native#20283

@adrienharnay
Copy link

And fixes babel/babel#8346

@xzilja
Copy link

xzilja commented Jul 21, 2018

Will likely fix danger/danger-js#627

@pvdz
Copy link

pvdz commented Jul 23, 2018

FYI Metro 42.2 depends on Babel 7 beta 54.

Closing this ticket as that seems to resolve it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants