Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation of serverless build fails #1476

Closed
RichardSteele opened this issue Aug 3, 2024 · 1 comment
Closed

Compilation of serverless build fails #1476

RichardSteele opened this issue Aug 3, 2024 · 1 comment

Comments

@RichardSteele
Copy link

I'd like to build libmysql only, but compilation after building with -DWITHOUT_SERVER=ON results in two errors.

The first one is:

In file included from /home/ab/mysql-5.6/include/lf.h:39,
                 from /home/ab/mysql-5.6/mysys/lf_alloc-pin.cc:121:
/home/ab/mysql-5.6/include/mysql/psi/mysql_statement.h: In function ‘long long unsigned int inline_mysql_get_statement_cpu_time(PSI_statement_locker*)’:
/home/ab/mysql-5.6/include/mysql/psi/mysql_statement.h:52:31: error: ‘psi_statement_service’ was not declared in this scope; did you mean ‘PSI_statement_key’?
   52 | #define PSI_STATEMENT_CALL(M) psi_statement_service->M
      |                               ^~~~~~~~~~~~~~~~~~~~~
/home/ab/mysql-5.6/include/mysql/psi/mysql_statement.h:437:16: note: in expansion of macro ‘PSI_STATEMENT_CALL’
  437 |     cpu_time = PSI_STATEMENT_CALL(get_statement_cpu_time)(locker);

Including inline_mysql_get_statement_cpu_time in a HAVE_PSI_STATEMENT_INTERFACE guard, since there's already a similar MYSQL_GET_STATEMENT_CPU_TIME macro, gets me past this error.

The next error is:

In file included from /home/ab/mysql-5.6/storage/perfschema/pfs_engine_table.h:41,
                 from /home/ab/mysql-5.6/storage/perfschema/table_write_statistics.h:35,
                 from /home/ab/mysql-5.6/sql/rpl_lag_manager.h:32,
                 from /home/ab/mysql-5.6/sql/mysqld.h:71,
                 from /home/ab/mysql-5.6/mysys/my_wsenv.cc:11:
/home/ab/mysql-5.6/storage/perfschema/pfs.h:73:8: error: ‘PSI_engine_data_lock_inspector’ does not name a type
   73 | extern PSI_engine_data_lock_inspector *g_data_lock_inspector[];
laurynas-biveinis added a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 5, 2024
@laurynas-biveinis
Partially fix -DWITHOUT_SERVER=ON build
5211ee4 
Do not declare inline_mysql_get_statement_cpu_time if
HAVE_PSI_STATEMENT_INTERFACE is not defined.

Will fix facebook#1476 together with other
PRs that squash to different commits.

Squash with f674306
@laurynas-biveinis laurynas-biveinis mentioned this issue Aug 5, 2024
Closed
laurynas-biveinis added a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 5, 2024
@laurynas-biveinis
Fix -DWITHOUT_SERVER=ON build, part 2
86c5e8d 
Mark inline_mysql_thread_get_held_locks arguments as maybe_unused to fix
compilation error when HAVE_PSI_THREAD_INTERFACE is not declared.

This partially fixes facebook#1476 together
with other PRs

Squash with d69bb8a
@laurynas-biveinis laurynas-biveinis mentioned this issue Aug 5, 2024
Closed
laurynas-biveinis added a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 5, 2024
@laurynas-biveinis
Remove redundant include
03c33cb 
Together with the other PRs, this fixes
facebook#1476

Squash with 515634e
@laurynas-biveinis laurynas-biveinis mentioned this issue Aug 5, 2024
Closed
laurynas-biveinis added a commit to laurynas-biveinis/mysql-5.6 that referenced this issue Aug 5, 2024
@laurynas-biveinis
Guard server-specific includes with MYSQL_SERVER
e10f903 
This fixes facebook#1476 together with the
other PRs

Squash with 66f9d88
@laurynas-biveinis laurynas-biveinis mentioned this issue Aug 5, 2024
Closed
sunshine-Chun pushed a commit to sunshine-Chun/mysql-5.6 that referenced this issue Sep 4, 2024
@luqun
[mysql-5.6][PR] Remove redundant include
e5501f9 
Summary:
Together with the other PRs, this fixes
facebook#1476

Squash with 515634e

Pull Request resolved: facebook#1479
GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.

Reviewers: saumitr, chni, #mysql_eng

Reviewed By: saumitr

Differential Revision: https://phabricator.intern.facebook.com/D61977201
@laurynas-biveinis
Copy link
Contributor

This issue was closed automatically, but it is not actually fixed until the remaining 3 PRs are merged

facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@laurynas-biveinis @facebook-github-bot
Partially fix -DWITHOUT_SERVER=ON build (#1477)
6a81e09 
Summary:
Do not declare inline_mysql_get_statement_cpu_time if
HAVE_PSI_STATEMENT_INTERFACE is not defined.

Will fix #1476 together with other
PRs that squash to different commits.

Squash with f674306

Pull Request resolved: #1477

Differential Revision: D62188754

fbshipit-source-id: 030309e3d07ea619a9874bf4c35dc3d2a57b6e89
facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@laurynas-biveinis @facebook-github-bot
Guard server-specific includes with MYSQL_SERVER (#1480)
de46c4c 
Summary:
This fixes #1476 together with the
other PRs

Squash with 66f9d88

Pull Request resolved: #1480

Differential Revision: D62188702

fbshipit-source-id: 167cfe1723bc3598412a1b91b5277fb6c2e45ea2
facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@laurynas-biveinis @facebook-github-bot
Fix -DWITHOUT_SERVER=ON build, part 2 (#1478)
04220ff 
Summary:
Mark inline_mysql_thread_get_held_locks arguments as maybe_unused to fix
compilation error when HAVE_PSI_THREAD_INTERFACE is not declared.

This partially fixes #1476 together
with other PRs

Squash with d69bb8a

Pull Request resolved: #1478

Differential Revision: D62188726

fbshipit-source-id: 12a8b710f1edae6623e8ab05eeccf469ed01fb60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@laurynas-biveinis @RichardSteele