Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Unnecessary dependencies from fbjs #188

Closed
Taylor123 opened this issue May 31, 2018 · 2 comments
Closed

Unnecessary dependencies from fbjs #188

Taylor123 opened this issue May 31, 2018 · 2 comments

Comments

@Taylor123
Copy link

Is it necessary for this package to be dependent on all of fbjs? I understand that it can make things easier for development, but I ran into an issue due to fbjs' dependency on isomorphi-fetch.

For the issue i ran into, see matthew-andrews/isomorphic-fetch#125

@the-spyke
Copy link

A have a similar issue, but with core-js:

└─┬ prop-types@15.6.1
  └─┬ fbjs@0.8.17
    └── core-js@1.2.7 

Even if all my other packages depend on core-js@2.x, npm continues to put core-js@1 from fbjs into the root node_modules, what leads to missing polyfills.

@ljharb
Copy link
Contributor

ljharb commented Feb 11, 2019

fbjs is no longer a dependency of this package.

@ljharb ljharb closed this as completed Feb 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants