From a8f4b21925aa6a8c44026be3469abae6b491f140 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 22 Jul 2022 11:10:55 +0100 Subject: [PATCH] Fix a couple of problems on the release runbook --- .../contributing/release-branch-cut-and-rc0.md | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/website/contributing/release-branch-cut-and-rc0.md b/website/contributing/release-branch-cut-and-rc0.md index 9e396cecbae..95fbc872981 100644 --- a/website/contributing/release-branch-cut-and-rc0.md +++ b/website/contributing/release-branch-cut-and-rc0.md @@ -29,19 +29,27 @@ Documents in this section go over steps to run different types of React Native r - Bump the Hermes version on the release branch using this command: ```bash - # Replace with the tag that will look like 'hermes-2022-02-21-RNv0.68.0-rc1-0172d30ac14e8c936c4fd2c435b799e0009aeb00' - ./scripts/bump-hermes-version.js -t + # Replace with the tag that will look like 'hermes-2022-07-20-RNv0.70.0-bc97c5399e0789c0a323f8e1431986e207a9e8ba' + ./scripts/hermes/bump-hermes-version.js -t ``` -### 2. Test the current changes +- Add and commit the extra file that got created at `sdks/hermes/.hermesversion`. -Before continuing further, follow the [testing guide](/contributing/release-testing) to ensure the code doesn't have any major issues. +### 2. Push the branch and test the current changes -### 3. Kick off the build of 0.{minor}.0-rc.0 +You can now push the branch you created so that others can also start testing: ```bash git push origin 0.69-stable +``` + +Before continuing further, follow the [testing guide](/contributing/release-testing) to ensure the code doesn't have any major issues. +### 3. Kick off the build of 0.{minor}.0-rc.0 + +Once you're done with the testing, you can kick-off the bump and publishing of RC0: + +``` # This will walk you through what version you are releasing ./scripts/bump-oss-version.js --to-version 0.69.0-rc.0 --token ```