From 0cac88fa65fd33dd6164ed2d6c4fbcdfa47f9e82 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sun, 30 Jul 2023 11:54:13 -0700 Subject: [PATCH] Android deprecate JSCJavaScriptExecutorFactory and JSCJavaScriptExecutor (#38594) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38594 These classes are deprecated in favor of com.facebook.react.jscexecutor instead changelog: [Android][Changed] Deprecate JSCJavaScriptExecutorFactory and JSCJavaScriptExecutor, use com.facebook.react.jscexecutor instead Reviewed By: christophpurrer, cortinico Differential Revision: D47483650 fbshipit-source-id: 5c29cf2bfff201468f171f1529e76ecf65244731 --- .../java/com/facebook/react/bridge/JSCJavaScriptExecutor.java | 2 ++ .../com/facebook/react/bridge/JSCJavaScriptExecutorFactory.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java index 8b6497b6ff3c65..cc114f8c534480 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutor.java @@ -10,7 +10,9 @@ import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; +/** @deprecated use {@link com.facebook.react.jscexecutor.JSCExecutor} instead. */ @DoNotStrip +@Deprecated /* package */ class JSCJavaScriptExecutor extends JavaScriptExecutor { static { ReactBridge.staticInit(); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutorFactory.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutorFactory.java index 5cfc327feabaee..97b25026f0f12f 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutorFactory.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JSCJavaScriptExecutorFactory.java @@ -7,6 +7,8 @@ package com.facebook.react.bridge; +/** @deprecated use {@link com.facebook.react.jscexecutor.JSCExecutorFactory} instead. */ +@Deprecated public class JSCJavaScriptExecutorFactory implements JavaScriptExecutorFactory { private final String mAppName; private final String mDeviceName;