From 1be38926c00d481c78f086b905fa3f24b1dc4ff5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Fri, 10 Aug 2018 13:59:40 -0700 Subject: [PATCH] Disable failing tests (#20622) Summary: `test_detox_end_to_end` and `test_objc_end_to_end` are both failing on master. This is polluting internal diffs that do not introduce failures. As we just now started tracking Circle CI on our internal builds, I want to make sure we only nag internal diffs when the failure can actually be attributed to the diff. The failures in the e2e tests precede the Circle CI integration and are adding unnecessary noise. Going forward, we will immediately go back to a diff and push the author to fix the broken CI, so this PR is a temporary fix. Pull Request resolved: https://github.com/facebook/react-native/pull/20622 Differential Revision: D9272360 Pulled By: hramos fbshipit-source-id: 2f8d22e35d301aa7eb67ed08f6deed21bf971acd --- .circleci/config.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index fd5b53d03059d9..212ac52a705f5f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -467,6 +467,7 @@ jobs: path: ~/react-native/reports/junit # Runs end to end tests (Detox) + # Disabled. test_detox_end_to_end: <<: *macos_defaults steps: @@ -674,16 +675,18 @@ workflows: requires: - checkout_code + # Disabled on master. + # End-to-end tests - - test_objc_end_to_end: - filters: *filter-ignore-gh-pages - requires: - - checkout_code + # - test_objc_end_to_end: + # filters: *filter-ignore-gh-pages + # requires: + # - checkout_code - - test_detox_end_to_end: - filters: *filter-ignore-gh-pages - requires: - - checkout_code + # - test_detox_end_to_end: + # filters: *filter-ignore-gh-pages + # requires: + # - checkout_code # Only runs on vX.X.X tags if all tests are green @@ -698,7 +701,7 @@ workflows: - test_javascript - test_objc - test_android - - test_objc_end_to_end + # - test_objc_end_to_end # Only runs on PRs analyze: