From 2d64d1d69360161c047c86a026403d8074ba28bb Mon Sep 17 00:00:00 2001 From: Tatiana Kapos Date: Thu, 17 Mar 2022 03:58:57 -0700 Subject: [PATCH] Fix RawPropsParser for Windows (#33432) Summary: Changes in https://github.com/facebook/react-native/compare/7cece3423...189c2c895 broke build for Windows because of a conversion from size_t to int. Adds a static cast to int to fix the error and restore windows build Error Message ``` ##[error]node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): Error C2220: the following warning is treated as an error 3>D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): error C2220: the following warning is treated as an error [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj] ##[warning]node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): **Warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data** 3>D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj] ``` ## Changelog [General] [Fixed] - Restore Windows build with RawPropsParser.cpp Pull Request resolved: https://github.com/facebook/react-native/pull/33432 Test Plan: Tested locally and changes pass in the react-native-windows pipeline, change is being merged into the main branch of react-native-windows. Reviewed By: philIip Differential Revision: D34907928 Pulled By: javache fbshipit-source-id: 8b76cbef0b637f2d607a8aefd2998322c3245713 --- ReactCommon/react/renderer/core/RawPropsParser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactCommon/react/renderer/core/RawPropsParser.cpp b/ReactCommon/react/renderer/core/RawPropsParser.cpp index 76b0f163dcb4b5..359b9f2f35ddd6 100644 --- a/ReactCommon/react/renderer/core/RawPropsParser.cpp +++ b/ReactCommon/react/renderer/core/RawPropsParser.cpp @@ -97,7 +97,7 @@ void RawPropsParser::preparse(RawProps const &rawProps) const noexcept { rawProps.keyIndexToValueIndex_.resize(keyCount, kRawPropsValueIndexEmpty); // Resetting the cursor, the next increment will give `0`. - rawProps.keyIndexCursor_ = keyCount - 1; + rawProps.keyIndexCursor_ = static_cast(keyCount - 1); switch (rawProps.mode_) { case RawProps::Mode::Empty: