From 3c634d82e522905bc91db6277842b10e1e3efeeb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Fri, 13 May 2022 12:51:09 -0700 Subject: [PATCH] Circle CI: Cache Hermes dirs in iOS jobs (#33828) Summary: Avoid re-building Hermes if a cache hit is found for the required Hermes version. Cache sdks/hermes and sdks/hermesc in Circle CI iOS jobs: `test_ios_rntester`, `build_ios`, and `test_ios`. `test_ios_rntester` "Install CocoaPod Dependencies" step reduced from 37m40s to 3m35s. `test_ios` "Generate RNTesterPods workspace" step reduced from 36m54s to 1m34s. Pull Request resolved: https://github.com/facebook/react-native/pull/33828 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D36365596 fbshipit-source-id: b5b6fe639f18b1724f80ab61c2262659c4987ff6 --- .circleci/config.yml | 54 +++++++++++++++++++++++++++++++++----------- 1 file changed, 41 insertions(+), 13 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5991c0e7681f1a..d226c4ca9beeec 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -246,6 +246,28 @@ commands: name: Report size of RNTester.app (analysis-bot) command: GITHUB_TOKEN="$PUBLIC_ANALYSISBOT_GITHUB_TOKEN_A""$PUBLIC_ANALYSISBOT_GITHUB_TOKEN_B" scripts/circleci/report-bundle-size.sh << parameters.platform >> || true + with_hermes_sdk_cache_span: + parameters: + steps: + type: steps + steps: + - run: + name: Setup Hermes cache + command: | + HERMES_VERSION_FILE="sdks/.hermesversion" + if [ ! -f "$HERMES_VERSION_FILE" ]; then + git ls-remote https://github.com/facebook/hermes main | cut -f 1 > $HERMES_VERSION_FILE + fi + - restore_cache: + keys: + - v1-hermes-{{ .Environment.CIRCLE_JOB }}-{{ checksum "sdks/.hermesversion" }} + - steps: << parameters.steps >> + - save_cache: + key: v1-hermes-{{ .Environment.CIRCLE_JOB }}-{{ checksum "sdks/.hermesversion" }} + paths: + - sdks/hermesc + - sdks/hermes + # ------------------------- # JOBS # ------------------------- @@ -423,11 +445,13 @@ jobs: name: Setup the CocoaPods environment command: bundle exec pod setup - - with_rntester_pods_cache_span: + - with_hermes_sdk_cache_span: steps: - - run: - name: Generate RNTesterPods Workspace - command: cd packages/rn-tester && bundle exec pod install --verbose + - with_rntester_pods_cache_span: + steps: + - run: + name: Generate RNTesterPods Workspace + command: cd packages/rn-tester && bundle exec pod install --verbose # ------------------------- # JOBS: iOS Unit Tests @@ -500,11 +524,13 @@ jobs: name: Setup the CocoaPods environment command: bundle exec pod setup - - with_rntester_pods_cache_span: + - with_hermes_sdk_cache_span: steps: - - run: - name: Generate RNTesterPods Workspace - command: cd packages/rn-tester && bundle exec pod install --verbose + - with_rntester_pods_cache_span: + steps: + - run: + name: Generate RNTesterPods Workspace + command: cd packages/rn-tester && bundle exec pod install --verbose # ------------------------- # Runs iOS unit tests @@ -743,11 +769,13 @@ jobs: - brew_install: package: cmake - - run: - name: Install CocoaPods dependencies - command: | - rm -rf packages/rn-tester/Pods - cd packages/rn-tester && bundle exec pod install + - with_hermes_sdk_cache_span: + steps: + - run: + name: Install CocoaPods dependencies + command: | + rm -rf packages/rn-tester/Pods + cd packages/rn-tester && bundle exec pod install # The macOS machine can run out of storage if Hermes is enabled and built from source. # Since this job does not use the iOS Simulator, deleting it provides a quick way to