Skip to content

Commit

Permalink
Reducing visibility of SimpleSettableFuture (#47438)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #47438

As part of sustainability week effort for switching to `internal` here:
https://fb.workplace.com/groups/251759413609061/permalink/872342228217440/

Reducing visibility of SimpleSettableFuture from `public` to `internal`

Changelog:
[Android] [Breaking] - Stable API - Make SimpleSettableFuture internal

Reviewed By: javache

Differential Revision: D65502193

fbshipit-source-id: 4bdd9b43684c8bc075271d76856ef848c52e6b12
  • Loading branch information
arushikesarwani94 authored and facebook-github-bot committed Nov 6, 2024
1 parent 17c1646 commit 3dec672
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
13 changes: 0 additions & 13 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
Original file line number Diff line number Diff line change
Expand Up @@ -1907,19 +1907,6 @@ public final class com/facebook/react/common/build/ReactBuildConfig {
public static final field IS_INTERNAL_BUILD Z
}

public final class com/facebook/react/common/futures/SimpleSettableFuture : java/util/concurrent/Future {
public fun <init> ()V
public fun cancel (Z)Z
public fun get ()Ljava/lang/Object;
public fun get (JLjava/util/concurrent/TimeUnit;)Ljava/lang/Object;
public final fun getOrThrow ()Ljava/lang/Object;
public final fun getOrThrow (JLjava/util/concurrent/TimeUnit;)Ljava/lang/Object;
public fun isCancelled ()Z
public fun isDone ()Z
public final fun set (Ljava/lang/Object;)V
public final fun setException (Ljava/lang/Exception;)V
}

public abstract interface class com/facebook/react/common/mapbuffer/MapBuffer : java/lang/Iterable, kotlin/jvm/internal/markers/KMappedMarker {
public static final field Companion Lcom/facebook/react/common/mapbuffer/MapBuffer$Companion;
public abstract fun contains (I)Z
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import java.util.concurrent.TimeoutException
* A super simple Future-like class that can safely notify another Thread when a value is ready.
* Does not support canceling.
*/
public class SimpleSettableFuture<T> : Future<T?> {
internal class SimpleSettableFuture<T> : Future<T?> {

private val readyLatch = CountDownLatch(1)
private var result: T? = null
Expand Down

0 comments on commit 3dec672

Please sign in to comment.