From 4976ff3ae284e4af4dbfadb622e7cbcb026ffbc9 Mon Sep 17 00:00:00 2001
From: Nick Gerleman <ngerlem@meta.com>
Date: Wed, 24 May 2023 23:10:11 -0700
Subject: [PATCH] Terminate instead of throwing if TurboModule callback
 double-called

Summary:
If a TM calls a completion callback, or resolves or rejects a promise multiple times, a C++ exception is thrown.

For an in the wild crash, we are getting this signal as:
1. `libdispatch` calls std::terminate while pumping a thread's message queue
2. The hooked FB app termination handler is called
3. Our termination handler introspects the currently thrown exception.
4. The handler introspecting the currently thrown exception sees this C++ exception being thrown, suggesting `libdispatch` termination may be due to unhandled C++ exception
4. We have lost the stack trace by this point of the code invoking the returned lambas

I think if we change the time of `abort()` to when the callback is called, we might be able to preserve the stack trace of module code calling the callback.

Differential Revision: D46175685

fbshipit-source-id: c0bae5522db1847535d19b001d039bdd37b8c8d4
---
 .../react/nativemodule/core/ReactCommon/TurboCxxModule.cpp    | 3 ++-
 .../core/platform/android/ReactCommon/JavaTurboModule.cpp     | 4 ++--
 .../core/platform/ios/ReactCommon/RCTTurboModule.mm           | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.cpp b/packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.cpp
index 71a5d3b4e0f045..fbe27c1e3c5db1 100644
--- a/packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.cpp
+++ b/packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboCxxModule.cpp
@@ -10,6 +10,7 @@
 #include <vector>
 
 #include <ReactCommon/TurboModuleUtils.h>
+#include <glog/logging.h>
 #include <jsi/JSIDynamic.h>
 
 using namespace facebook;
@@ -24,7 +25,7 @@ CxxModule::Callback makeTurboCxxModuleCallback(
   return [weakWrapper,
           wrapperWasCalled = false](std::vector<folly::dynamic> args) mutable {
     if (wrapperWasCalled) {
-      throw std::runtime_error("callback arg cannot be called more than once");
+      LOG(FATAL) << "callback arg cannot be called more than once";
     }
 
     auto strongWrapper = weakWrapper.lock();
diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.cpp b/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.cpp
index 9f57f4d2c7f59b..616861539d1749 100644
--- a/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.cpp
+++ b/packages/react-native/ReactCommon/react/nativemodule/core/platform/android/ReactCommon/JavaTurboModule.cpp
@@ -10,6 +10,7 @@
 #include <string>
 
 #include <fbjni/fbjni.h>
+#include <glog/logging.h>
 #include <jsi/jsi.h>
 
 #include <ReactCommon/TurboModule.h>
@@ -83,8 +84,7 @@ jni::local_ref<JCxxCallbackImpl::JavaPart> createJavaCallbackFromJSIFunction(
        callbackWrapperOwner = std::move(callbackWrapperOwner),
        wrapperWasCalled = false](folly::dynamic responses) mutable {
         if (wrapperWasCalled) {
-          throw std::runtime_error(
-              "Callback arg cannot be called more than once");
+          LOG(FATAL) << "callback arg cannot be called more than once";
         }
 
         auto strongWrapper = weakWrapper.lock();
diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
index f5bcde5867565b..7c4cb68787ac81 100644
--- a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
+++ b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.mm
@@ -8,6 +8,7 @@
 #import "RCTTurboModule.h"
 #import "RCTBlockGuard.h"
 
+#include <glog/logging.h>
 #import <objc/message.h>
 #import <objc/runtime.h>
 #import <atomic>
@@ -184,7 +185,7 @@ id convertJSIValueToObjCObject(jsi::Runtime &runtime, const jsi::Value &value, s
   BOOL __block wrapperWasCalled = NO;
   RCTResponseSenderBlock callback = ^(NSArray *responses) {
     if (wrapperWasCalled) {
-      throw std::runtime_error("callback arg cannot be called more than once");
+      LOG(FATAL) << "callback arg cannot be called more than once";
     }
 
     auto strongWrapper = weakWrapper.lock();