Skip to content

Commit

Permalink
Internalize TaskCompletionSource class (#47543)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #47543

TaskCompletionSource is public but it shouldn't, in this diff I'm making it intenral

changelog: [Android][Breaking] Reduce visibility of TaskCompletionSource class

Reviewed By: javache

Differential Revision: D65738324

fbshipit-source-id: 61db35a408162c53398b20e45a52f3eb46de1eae
  • Loading branch information
mdvacca authored and facebook-github-bot committed Nov 11, 2024
1 parent a4eb579 commit 4f55161
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
11 changes: 0 additions & 11 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
Original file line number Diff line number Diff line change
Expand Up @@ -3895,17 +3895,6 @@ public abstract interface class com/facebook/react/runtime/internal/bolts/Task$U
public abstract fun unobservedException (Lcom/facebook/react/runtime/internal/bolts/Task;Lcom/facebook/react/runtime/internal/bolts/UnobservedTaskException;)V
}

public final class com/facebook/react/runtime/internal/bolts/TaskCompletionSource {
public fun <init> ()V
public final fun getTask ()Lcom/facebook/react/runtime/internal/bolts/Task;
public final fun setCancelled ()V
public final fun setError (Ljava/lang/Exception;)V
public final fun setResult (Ljava/lang/Object;)V
public final fun trySetCancelled ()Z
public final fun trySetError (Ljava/lang/Exception;)Z
public final fun trySetResult (Ljava/lang/Object;)Z
}

public final class com/facebook/react/shell/MainPackageConfig {
public fun <init> (Lcom/facebook/imagepipeline/core/ImagePipelineConfig;)V
public final fun getFrescoConfig ()Lcom/facebook/imagepipeline/core/ImagePipelineConfig;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ package com.facebook.react.runtime.internal.bolts
* access to the consumer side through the getTask() method while isolating the Task's completion
* mechanisms from the consumer.
*/
public class TaskCompletionSource<TResult>() {
internal class TaskCompletionSource<TResult>() {

/** @return the Task associated with this TaskCompletionSource. */
public val task: Task<TResult> = Task()
Expand Down

0 comments on commit 4f55161

Please sign in to comment.