From a4b3118942018f57cd1d8c25036efb2269c89a5a Mon Sep 17 00:00:00 2001 From: Eric Rozell Date: Fri, 11 Aug 2023 09:22:06 -0700 Subject: [PATCH] Fixes regression of prop parsing for elevation Summary: When refactoring ViewProps in D47492635, `elevation` prop parsing was dropped. This restores it. ## Changelog: [General] [Fixed] - Fabric regression for elevation prop in Android Differential Revision: D48269510 fbshipit-source-id: 5b9f07a7299d2e30f37b45e6fb7afcd81d14240d --- .../renderer/components/view/HostPlatformViewProps.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp index 85f74f20a2c45b..9559d3dcb69512 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp @@ -23,6 +23,14 @@ HostPlatformViewProps::HostPlatformViewProps( RawProps const &rawProps, bool shouldSetRawProps) : BaseViewProps(context, sourceProps, rawProps, shouldSetRawProps), + elevation( + CoreFeatures::enablePropIteratorSetter ? sourceProps.elevation + : convertRawProp( + context, + rawProps, + "elevation", + sourceProps.elevation, + {})), nativeBackground( CoreFeatures::enablePropIteratorSetter ? sourceProps.nativeBackground