From a7e5c96a3d11671ed45b5d4f02334e8cc988ce9e Mon Sep 17 00:00:00 2001
From: Nick Gerleman <ngerlem@meta.com>
Date: Tue, 13 Jun 2023 15:50:01 -0700
Subject: [PATCH] Localize Talkback strings (#37856)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37856

These strings are spoken to the user when using an ascessibility role or state not natively supported by Talkback.

We can enable these for translation by removing flags to disable localization, and adding descriptions to each string. These are derived from MDN for ARIA (used for iOS strings), along with Android and iOS documentation.

Note that this was explicitly disabled as part of D15087192 because of creating spam which was hitting the GitHub repo, but when translation was enabled for the dev menu, this ended up being a non-issue after initial translation. And we really do want these to be localized.

Changelog:
[Android][Fixed] - Localize Talkback strings

Reviewed By: cortinico

Differential Revision: D46692127

fbshipit-source-id: 6da4a181e03f46bad850e4385b94155695a142a8
---
 .../res/views/uimanager/values/strings.xml    | 103 ++++++++++++++++++
 .../uimanager/values/strings_unlocalized.xml  | 103 ------------------
 2 files changed, 103 insertions(+), 103 deletions(-)
 create mode 100644 packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings.xml
 delete mode 100644 packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml

diff --git a/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings.xml b/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings.xml
new file mode 100644
index 00000000000000..a2f6ad5263150a
--- /dev/null
+++ b/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings.xml
@@ -0,0 +1,103 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <string
+    name="link_description"
+    description="provides an interactive reference to a resource"
+    >Link</string>
+  <string
+    name="image_description"
+    description="images, code snippets, text, emojis, or other content that can be combined to deliver information in a visual manner"
+    >Image</string>
+  <string
+    name="imagebutton_description"
+    description="Displays a button with an image (instead of text) that can be pressed or clicked by the user"
+    >Button, Image</string>
+  <string
+    name="header_description"
+    description="heading to a page or section"
+    >Heading</string>
+  <string
+    name="alert_description"
+    description="important, and usually time-sensitive, information"
+    >Alert</string>
+  <string
+    name="combobox_description"
+    description="input that controls another element that can pop up to help the user set the value of that input"
+    >Combo Box</string>
+  <string
+    name="menu_description"
+    description="offers a list of choices to the user"
+    >Menu</string>
+  <string
+    name="menubar_description"
+    description="presentation of menu that usually remains visible and is usually presented horizontally"
+    >Menu Bar</string>
+  <string
+    name="menuitem_description"
+    description="an option in a set of choices contained by a menu or menubar"
+    >Menu Item</string>
+  <string
+    name="progressbar_description"
+    description="displays the progress status for tasks that take a long time"
+    >Progress Bar</string>
+  <string
+    name="radiogroup_description"
+    description="a group of radio buttons"
+    >Radio Group</string>
+  <string
+    name="scrollbar_description"
+    description="controls the scrolling of content within a viewing area"
+    >Scroll Bar</string>
+  <string
+    name="spinbutton_description"
+    description="defines a type of range that expects the user to select a value from among discrete choices"
+    >Spin Button</string>
+  <string
+    name="rn_tab_description"
+    description="an interactive element inside a tablist"
+    >Tab</string>
+  <string
+    name="tablist_description"
+    description="container for a set of tabs"
+    >Tab List</string>
+  <string
+    name="timer_description"
+    description="a numerical counter listing the amount of elapsed time from a starting point or the remaining time until an end point"
+    >Timer</string>
+  <string
+    name="toolbar_description"
+    description="a collection of commonly used function buttons or controls represented in a compact visual form"
+    >Tool Bar</string>
+  <string
+    name="summary_description"
+    description="provides a summary of current conditions, settings, or state, such as the current temperature in the Weather app"
+    >Summary</string>
+  <string
+    name="state_busy_description"
+    description="an element currently being updated or modified"
+    >busy</string>
+  <string
+    name="state_expanded_description"
+    description="a menu, dialog, accordian panel, or other widget which is expanded"
+    >expanded</string>
+  <string
+    name="state_collapsed_description"
+    description="a menu, dialog, accordian panel, or other widget which is collapsed"
+    >collapsed</string>
+  <string
+    name="state_unselected_description"
+    description="used to indicate which elements within single-selection and multiple-selection composite widgets are not selected"
+    >unselected</string>
+  <string
+    name="state_on_description"
+    description="a switch in its enabled state"
+    >on</string>
+  <string
+    name="state_off_description"
+    description="a switch in its disabled state"
+    >off</string>
+  <string
+    name="state_mixed_description"
+    description="a checkbox, radio button, or other widget which is both checked and unchecked"
+    >mixed</string>
+</resources>
diff --git a/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml b/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
deleted file mode 100644
index d06603f611372a..00000000000000
--- a/packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
+++ /dev/null
@@ -1,103 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-  <string
-    name="link_description"
-    translatable="false"
-    >Link</string>
-  <string
-    name="image_description"
-    translatable="false"
-    >Image</string>
-  <string
-    name="imagebutton_description"
-    translatable="false"
-    >Button, Image</string>
-  <string
-    name="header_description"
-    translatable="false"
-    >Heading</string>
-  <string
-    name="alert_description"
-    translatable="false"
-    >Alert</string>
-  <string
-    name="combobox_description"
-    translatable="false"
-    >Combo Box</string>
-  <string
-    name="menu_description"
-    translatable="false"
-    >Menu</string>
-  <string
-    name="menubar_description"
-    translatable="false"
-    >Menu Bar</string>
-  <string
-    name="menuitem_description"
-    translatable="false"
-    >Menu Item</string>
-  <string
-    name="progressbar_description"
-    translatable="false"
-    >Progress Bar</string>
-  <string
-    name="radiogroup_description"
-    translatable="false"
-    >Radio Group</string>
-  <string
-    name="scrollbar_description"
-    translatable="false"
-    >Scroll Bar</string>
-  <string
-    name="spinbutton_description"
-    translatable="false"
-    >Spin Button</string>
-  <string
-    name="rn_tab_description"
-    translatable="false"
-    >Tab</string>
-  <string
-    name="tablist_description"
-    translatable="false"
-    >Tab List</string>
-  <string
-    name="timer_description"
-    translatable="false"
-    >Timer</string>
-  <string
-    name="toolbar_description"
-    translatable="false"
-    >Tool Bar</string>
-  <string
-    name="summary_description"
-    translatable="false"
-    >Summary</string>
-  <string
-    name="state_busy_description"
-    translatable="false"
-    >busy</string>
-  <string
-    name="state_expanded_description"
-    translatable="false"
-    >expanded</string>
-  <string
-    name="state_collapsed_description"
-    translatable="false"
-    >collapsed</string>
-  <string
-    name="state_unselected_description"
-    translatable="false"
-    >unselected</string>
-  <string
-    name="state_on_description"
-    translatable="false"
-    >on</string>
-  <string
-    name="state_off_description"
-    translatable="false"
-    >off</string>
-  <string
-    name="state_mixed_description"
-    translatable="false"
-    >mixed</string>
-</resources>