From ba0c3ffd5b46963a8bb27b40eb396965535cd927 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Wed, 20 Feb 2019 23:04:14 -0800 Subject: [PATCH] ReactTextView extends AppCompatTextView (#23321) Summary: Google recommends to use AppCompat widgets, and this PR changes ReactTextView to extend AppCompatTextView. [Android] [Changed] - ReactTextView extends AppCompatTextView Pull Request resolved: https://github.com/facebook/react-native/pull/23321 Differential Revision: D13986149 Pulled By: cpojer fbshipit-source-id: 878849fff12dc5478bb0d0952b2c22695391e81a --- ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK | 2 ++ .../java/com/facebook/react/views/text/ReactTextView.java | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK index 449f27adafead5..2008eda3ce16a3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK @@ -9,6 +9,8 @@ rn_android_library( ], deps = [ YOGA_TARGET, + react_native_dep("third-party/android/support/v4:lib-support-v4"), + react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"), react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"), react_native_dep("third-party/java/infer-annotations:infer-annotations"), react_native_dep("third-party/java/jsr-305:jsr-305"), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java index f2f739b239c8a5..7e99cb1429d8df 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java @@ -10,13 +10,13 @@ import android.content.Context; import android.graphics.drawable.Drawable; import android.os.Build; +import android.support.v7.widget.AppCompatTextView; import android.text.Layout; import android.text.Spannable; import android.text.Spanned; import android.text.TextUtils; import android.view.Gravity; import android.view.ViewGroup; -import android.widget.TextView; import com.facebook.common.logging.FLog; import com.facebook.react.common.ReactConstants; import com.facebook.react.uimanager.ReactCompoundView; @@ -24,7 +24,7 @@ import com.facebook.react.views.view.ReactViewBackgroundManager; import javax.annotation.Nullable; -public class ReactTextView extends TextView implements ReactCompoundView { +public class ReactTextView extends AppCompatTextView implements ReactCompoundView { private static final ViewGroup.LayoutParams EMPTY_LAYOUT_PARAMS = new ViewGroup.LayoutParams(0, 0);