From bcac3c4d9c2b7c712018c9686dfa620479674082 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste LARRIVIERE <76693792+jblarriviere@users.noreply.github.com> Date: Wed, 3 Apr 2024 04:43:11 -0700 Subject: [PATCH] fix: build settings for custom build configuration (#43780) Summary: This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes https://github.com/facebook/react-native/issues/43185 Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in https://github.com/facebook/react-native/issues/43185 This now applies the setting to every configuration ending with `Debug` ## Changelog: [IOS] [CHANGED] - fix: build settings for custom build configuration Pull Request resolved: https://github.com/facebook/react-native/pull/43780 Reviewed By: dmytrorykun Differential Revision: D55688996 Pulled By: cipolleschi fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c --- packages/react-native/scripts/cocoapods/utils.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/scripts/cocoapods/utils.rb b/packages/react-native/scripts/cocoapods/utils.rb index f9b7a18f950116..06c07b986a60b7 100644 --- a/packages/react-native/scripts/cocoapods/utils.rb +++ b/packages/react-native/scripts/cocoapods/utils.rb @@ -189,7 +189,7 @@ def self.add_build_settings_to_pod(installer, settings_name, settings_value, tar installer.target_installation_results.pod_target_installation_results.each do |pod_name, target_installation_result| if pod_name.to_s == target_pod_name target_installation_result.native_target.build_configurations.each do |config| - if configuration == nil || (configuration != nil && configuration == config.name) + if configuration == nil || (configuration != nil && config.name.include?(configuration)) config.build_settings[settings_name] ||= '$(inherited) ' config.build_settings[settings_name] << settings_value end