Skip to content

Commit

Permalink
Stable API - Make NativeModulePerfLogger internal (#47415)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #47415

This class should not be accessed directly, therefore I'm making it internal.
Technically breaking but I verified that there are no meaningful usages in OSS:
https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.reactperflogger.NativeModulePerfLogger

Changelog:
[Android] [Breaking] - Stable API - Make NativeModulePerfLogger internal

Reviewed By: mdvacca

Differential Revision: D65479550

fbshipit-source-id: 545c33e2c526e396084af65fc19314f59c8a74f8
  • Loading branch information
cortinico authored and facebook-github-bot committed Nov 5, 2024
1 parent d1fb01c commit d7d5de9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 27 deletions.
16 changes: 0 additions & 16 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
Original file line number Diff line number Diff line change
Expand Up @@ -3763,22 +3763,6 @@ public abstract interface class com/facebook/react/packagerconnection/Responder
public abstract fun respond (Ljava/lang/Object;)V
}

public abstract class com/facebook/react/reactperflogger/NativeModulePerfLogger {
protected fun <init> ()V
protected abstract fun initHybrid ()Lcom/facebook/jni/HybridData;
protected final fun maybeLoadOtherSoLibraries ()V
public abstract fun moduleCreateCacheHit (Ljava/lang/String;I)V
public abstract fun moduleCreateConstructEnd (Ljava/lang/String;I)V
public abstract fun moduleCreateConstructStart (Ljava/lang/String;I)V
public abstract fun moduleCreateEnd (Ljava/lang/String;I)V
public abstract fun moduleCreateFail (Ljava/lang/String;I)V
public abstract fun moduleCreateSetUpEnd (Ljava/lang/String;I)V
public abstract fun moduleCreateSetUpStart (Ljava/lang/String;I)V
public abstract fun moduleCreateStart (Ljava/lang/String;I)V
public abstract fun moduleDataCreateEnd (Ljava/lang/String;I)V
public abstract fun moduleDataCreateStart (Ljava/lang/String;I)V
}

public abstract class com/facebook/react/runtime/BindingsInstaller {
public fun <init> (Lcom/facebook/jni/HybridData;)V
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ package com.facebook.react.reactperflogger

import com.facebook.jni.HybridData

public abstract class NativeModulePerfLogger protected constructor() {
internal abstract class NativeModulePerfLogger protected constructor() {

@Suppress("NoHungarianNotation") private val mHybridData: HybridData

Expand All @@ -20,25 +20,25 @@ public abstract class NativeModulePerfLogger protected constructor() {

protected abstract fun initHybrid(): HybridData

public abstract fun moduleDataCreateStart(moduleName: String, id: Int)
abstract fun moduleDataCreateStart(moduleName: String, id: Int)

public abstract fun moduleDataCreateEnd(moduleName: String, id: Int)
abstract fun moduleDataCreateEnd(moduleName: String, id: Int)

public abstract fun moduleCreateStart(moduleName: String, id: Int)
abstract fun moduleCreateStart(moduleName: String, id: Int)

public abstract fun moduleCreateCacheHit(moduleName: String, id: Int)
abstract fun moduleCreateCacheHit(moduleName: String, id: Int)

public abstract fun moduleCreateConstructStart(moduleName: String, id: Int)
abstract fun moduleCreateConstructStart(moduleName: String, id: Int)

public abstract fun moduleCreateConstructEnd(moduleName: String, id: Int)
abstract fun moduleCreateConstructEnd(moduleName: String, id: Int)

public abstract fun moduleCreateSetUpStart(moduleName: String, id: Int)
abstract fun moduleCreateSetUpStart(moduleName: String, id: Int)

public abstract fun moduleCreateSetUpEnd(moduleName: String, id: Int)
abstract fun moduleCreateSetUpEnd(moduleName: String, id: Int)

public abstract fun moduleCreateEnd(moduleName: String, id: Int)
abstract fun moduleCreateEnd(moduleName: String, id: Int)

public abstract fun moduleCreateFail(moduleName: String, id: Int)
abstract fun moduleCreateFail(moduleName: String, id: Int)

/** Subclasses will override this method to load their own SO libraries. */
@Synchronized
Expand Down

0 comments on commit d7d5de9

Please sign in to comment.