Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigator should call componentWillUnmount on a scene after the pop transition completes. #1025

Closed
mwilc0x opened this issue Apr 26, 2015 · 1 comment
Closed

Navigator should call componentWillUnmount on a scene after the pop transition completes. #1025

mwilc0x opened this issue Apr 26, 2015 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@mwilc0x
Copy link
Contributor

mwilc0x commented Apr 26, 2015

As mentioned in #1014, after dismissing a scene via a gesture using Navigator, the dismissed component's componentWillUnmount lifecycle hook is not being called.

I have submitted a fix in #1018 which calls this._handlePop() when a gesture triggers a route change. The result is that the componentWillUnmount hook of the dismissed component is called.

Any help to review this and make sure it is the right fix is appreciated. Thanks. :)
@vitch vitch mentioned this issue Apr 29, 2015
Closed
@brentvatne
Copy link
Collaborator

This is fixed now!

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brentvatne @mwilc0x @react-native-bot