Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][TextInput] emoji after a new line make the line disappear #10929

Closed
ahanriat opened this issue Nov 14, 2016 · 6 comments
Closed

[iOS][TextInput] emoji after a new line make the line disappear #10929

ahanriat opened this issue Nov 14, 2016 · 6 comments
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@ahanriat
Copy link
Contributor

ahanriat commented Nov 14, 2016

Description

On controlled TextInput, adding an emoji after a new line make the line disappear.
Adding whatever character after make the line appear again.

Reproduction

The code https://rnplay.org/apps/XmdwqQ

screen capture on 2016-11-14 at 11-58-02

Additional Information

React Native: reproduced on 0.36.0, 0.37.0 & 0.38.0-rc.0
Platform: iOS
Component: TextInput

Thanks for your help 🚀

Edit 11/21/2016

The issue disappears when forcing the lineHeight of the Text. ( Thanks @linmic )

@vinch
Copy link

vinch commented Nov 16, 2016

Same issue :(

@linmic
Copy link
Contributor

linmic commented Nov 21, 2016

@ahanriat @vinch Use the value property instead? Is there any reasons should you wrap another <Text> in <TextInput>?

Employ value here should avoid the issue you mentioned. Alternatively, you can specify a proper lineHeight for the <Text>, which would work for you as well.

@vinch
Copy link

vinch commented Nov 21, 2016

@linmic Indeed, if I use the value property instead of having a <Text> inside the <TextInput>, I don't have the problem anymore. I think I had to do that because font styles were not applied to <TextInput> but the bug seems to have been fixed since then: #2140
Thanks!

@ahanriat
Copy link
Contributor Author

@linmic thanks for the tips (lineHeight), it fixes the issue for me.
I'll update the description of the issue to provide some hints to fix this for good.

@shergin shergin added the Platform: iOS iOS applications. label Mar 16, 2017
@hramos
Copy link
Contributor

hramos commented Jul 20, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 20, 2017
@hramos hramos closed this as completed Jul 20, 2017
@KavithaSaras
Copy link

@ahanriat can you please share this plugin link?

@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants