Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextInput] Vertical padding on a <TextInput> not correctly computed #1105

Closed
ide opened this issue May 2, 2015 · 4 comments
Closed

[TextInput] Vertical padding on a <TextInput> not correctly computed #1105

ide opened this issue May 2, 2015 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented May 2, 2015

A text field's height appears to be calculated as max(intrinsic height, vertical padding) instead of intrinsic height + vertical padding.

Repro:

<View style={{flexDirection: 'row'}}>
  <TextInput style={{flex: 1, paddingBottom: 50, backgroundColor: '#ddd'}} value="hello" />
</View>

The text field is 50pt tall and the text is half-clipped at the top.

@brentvatne brentvatne changed the title Vertical padding on a <TextInput> not correctly computed [TextInput] Vertical padding on a <TextInput> not correctly computed May 30, 2015
@brentvatne
Copy link
Collaborator

Is this collapsable into #1287 @ide?

@ide
Copy link
Contributor Author

ide commented May 30, 2015

This is a different problem with the layout engine.

@brentvatne
Copy link
Collaborator

Ah okay, just wanted to be sure

@brentvatne
Copy link
Collaborator

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out it's new home: https://productpains.com/post/react-native/textinput-vertical-padding-on-a-textinput-not-correctly-computed

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants