Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-git-upgrade doesn't work with local user config #12334

Closed
jpaas opened this issue Feb 10, 2017 · 2 comments
Closed

react-native-git-upgrade doesn't work with local user config #12334

jpaas opened this issue Feb 10, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jpaas
Copy link

jpaas commented Feb 10, 2017

I don't have a global git config for user.email because I use different emails for different repos. Instead I set it in each repo. Even though git config -l confirms my user.email is set in my local repo, react-native-git-upgrade refuses to run because it believes it isn't set.

In order to run react-native-git-upgrade, I have to set user.email in my global .gitconfig. So I think whatever check it is doing is probably incorrect. It shouldn't care whether its set globally, only locally.

This has been around since react-native-git-upgrade was launched on up to 0.42.rc-2

@lacker
Copy link
Contributor

lacker commented Feb 10, 2017

Would you be interested in sending a PR to fix this?

@jpaas
Copy link
Author

jpaas commented Feb 11, 2017

So I dug into this a bit further and react-native-git-upgrade does a simple git commit -m "snapshot". The issues with global vs local config have been reported by many people in regard to many other projects that use git, but in the end I'd say its a problem with git itself.

@jpaas jpaas closed this as completed Feb 11, 2017
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants