Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CocoaPods] Add support for the C++ bridge #13225

Closed
ide opened this issue Mar 30, 2017 · 9 comments
Closed

[CocoaPods] Add support for the C++ bridge #13225

ide opened this issue Mar 30, 2017 · 9 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@ide
Copy link
Contributor

ide commented Mar 30, 2017

This is an issue to track adding support for the C++ bridge to the Podspec. @mhorowitz is one of the authors of the new bridge. The longer-term plan is to move completely to the C++ bridge while giving people a period of time to transition. At first the C++ bridge will be opt-in, then opt-out, and then the legacy bridge will be removed.

I haven't put much thought into how we want to approach this with the Podspec and wanted to start a discussion here.

cc @alloy @janicduplessis - you guys might have some thoughts

@mhorowitz
Copy link
Contributor

Thanks, @ide ! I don't know much about podspecs, but I'll answer whatever I can about the new bridge to get you guys moving.

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@ide ide removed the Icebox label Jul 25, 2017
@ide
Copy link
Contributor Author

ide commented Jul 25, 2017

This is underway anyway so removing Icebox.

@hramos
Copy link
Contributor

hramos commented Jul 26, 2017

The icebox script doesn't account for long-running discussions. It's OK to re-open this.

@hramos hramos reopened this Jul 26, 2017
@mhorowitz
Copy link
Contributor

At this point, this is "done" in the 0.47 rc. But I've gotten very little feedback to know if it's actually working for people.

If you use it, and it works for you, please comment here or let me know.

@TheTekton
Copy link

@mhorowitz Our Podfile is configured for the CxxBridge, in 0.47.2, with no issues to report.

@ragnorc
Copy link

ragnorc commented Sep 4, 2017

#14326

@stale
Copy link

stale bot commented Nov 3, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 3, 2017
@ide
Copy link
Contributor Author

ide commented Nov 4, 2017

Closing this umbrella issue since basic support is working and people are using it in production.

@ide ide closed this as completed Nov 4, 2017
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

5 participants