Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated.event fail to map two args #13294

Closed
MQZhangThu opened this issue Apr 4, 2017 · 5 comments
Closed

Animated.event fail to map two args #13294

MQZhangThu opened this issue Apr 4, 2017 · 5 comments
Labels
Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Resolution: Locked This issue was locked by the bot.

Comments

@MQZhangThu
Copy link

MQZhangThu commented Apr 4, 2017

In 0.42.0 version, when using Animated.event in Animated.ScrollView to respectively map e.nativeEvent.contentOffset.y and e.nativeEvent.contentSize.height to two Animated value (this.state.scrollY and this.state.contentSizeHeight) as below, only the first one (i.e., this.state.scrollY) was mapped, while the second one (i.e., this.state.contentSizeHeight) does not work.

onScroll={Animated.event(
              [{
                nativeEvent: { contentOffset: { y: this.state.scrollY } }
              },{
                nativeEvent: { contentSize: { height: this.state.contentSizeHeight } }
              }],
              { useNativeDriver: true },
            )}

Below is the test code:

componentDidMount() {
      this.state.scrollY.addListener(e => {
        console.log('scrollY', e);  // OK
      })
      this.state.contentSizeHeight.addListener(e => {
        console.log('contentSizeHeight', e); // <--- this line does not run
      })
}
@hramos
Copy link
Contributor

hramos commented Apr 4, 2017

Can you provide a minimal amount of code to reproduce this using Snack?

@MQZhangThu
Copy link
Author

MQZhangThu commented Apr 5, 2017

@hramos here is the Snack link
while scrolling the content, you will see that only something like scrollY {"value":2060} is printed via the console log, while contentSizeHeight is not.

@hramos hramos added the Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. label Apr 5, 2017
@willdawsonme
Copy link

I'm pretty sure this was fixed with #12697 and should be in 0.44.0-rc.4.

@hramos
Copy link
Contributor

hramos commented Apr 7, 2017

Thanks @willdawsonme. We should probably update our issue guidelines to ask that bugs be tested against master.

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants