Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn warning with react-addons-shallow-compare on RN 0.43.0 (released) #13310

Closed
fungilation opened this issue Apr 5, 2017 · 5 comments
Closed

Yarn warning with react-addons-shallow-compare on RN 0.43.0 (released) #13310

fungilation opened this issue Apr 5, 2017 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@fungilation
Copy link

This warning shows up on any yarn upgrade or install. This didn't show up before RN 0.43.

warning "react-addons-shallow-compare@15.5.0-alpha.0" has incorrect peer dependency "react@^15.5.0".
@nhducit
Copy link

nhducit commented Apr 5, 2017

@fungilation #13309 (comment)

@janicduplessis
Copy link
Contributor

You can ignore the warning it won't cause any issue. It will be fixed soon.

@Swizec
Copy link

Swizec commented Apr 5, 2017

It or something related to it causes issues.

--> #13311

@grabbou
Copy link
Contributor

grabbou commented Apr 5, 2017

0.43.1 is being now released with a fix

@grabbou grabbou closed this as completed Apr 5, 2017
@npomfret
Copy link
Contributor

npomfret commented Apr 5, 2017

Can't get 43.1 to work. Still getting an error saying unable to resolve module... react-addons-shallow-compare

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Swizec @grabbou @janicduplessis @fungilation @nhducit @npomfret @react-native-bot