[Android] ReactRootView layout configuration inside native app

[ahetawal-p]

Trying to add a ReactRootView to my existing layout which looks like this

ReactRootView contentView = new ReactRootView(context);
LinearLayout container = (LinearLayout) parent.findViewById(R.id.view_container);
contentView.startReactApplication(reactInstanceManager, "MyComponent", null)
container.addView(contentView, -1, new LinearLayout.LayoutParams(MATCH_PARENT, WRAP_CONTENT));

With the above setup, my reactview never gets rendered, since the height is always 0.
I have to explicitly provide the height to my layout as -

container.addView(contentView, -1, new LinearLayout.LayoutParams(MATCH_PARENT, 200));

How does ReactRootView handles the layout params when embedded inside a android native app ?

[hslls]

I encountered the same problem.

[hramos]

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

• Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
• If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
• Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

[githubdoramon]

@ahetawal-p you just saved my life after a lot of struggle, hahahaha.... I can understand why, but people don't seem to give a f*** for using react-native with existing native apps, which I think is the best use for it. Thanks a lot