Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexWrap has definite, reproducible buggy behavior (!) #14429

Closed
idibidiart opened this issue Jun 9, 2017 · 5 comments
Closed

flexWrap has definite, reproducible buggy behavior (!) #14429

idibidiart opened this issue Jun 9, 2017 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@idibidiart
Copy link

idibidiart commented Jun 9, 2017

Reporting Bugs

Report a single bug per issue.

Since issue #8960 has so many bugs some of which turned out to be normal behavior per the Flexbox spec, I figured we need a new issue that focuses on an actual, definite bug

Here is the issue, first reported by @EyalSi

I've made a simple version of the code posted by @EyalSi in #8960 that shows an interesting definitely buggy behavior:

The only difference in the two screens below is a single extra "." after the last "test"

image1

image2

@kulmajaba there is more buggy behavior that I've encountered that may or may not be related to this

      <ScrollView > 
          <View style={{flexDirection: 'row',flexWrap:'wrap', backgroundColor: 'orange'}}>
              <View style={{margin: 15, backgroundColor: 'yellow'}}>
              <Text style={{fontSize:20}}> test test test test </Text>
              </View>
              <View style={{margin: 15, backgroundColor: 'yellow'}}>
              <Text style={{fontSize:20}}> test test test </Text>
              </View>
              <View style={{margin: 15, backgroundColor: 'yellow'}}>
              <Text style={{fontSize:20}}> test </Text>
              </View>

              <View style={{margin: 15, backgroundColor: 'red'}}>
              <Text style={{fontSize:20}}> test.. </Text>
              </View>

          </View>
          <Text>
          TEST
          </Text>
      </ScrollView>

This is only an issue when setting margins. If you set padding instead there is no issue.

Additional Information

  • React Native version: 0.43+
  • Platform: iOS and Android
  • Development Operating System: MacOS
  • Dev tools: Expo
@hramos
Copy link
Contributor

hramos commented Jun 9, 2017

Do you have a Snack that easily reproduces this?

@idibidiart
Copy link
Author

@hramos

here is the buggy version:

https://snack.expo.io/SkhAnauGZ

same code without the bug with only difference being the last Text is "test test" instead of "test"

https://snack.expo.io/BkQtnTOG-

Expo in the Snack simulator fails to load sometimes so if that happens just reload it inside the simulator.

@idibidiart
Copy link
Author

curious, any update on this?

@hramos

@hramos
Copy link
Contributor

hramos commented Jun 13, 2017

@idibidiart nothing on our side (there's still many open issues to go through and prioritize). Feel free to send a PR if you investigate this further.

@hramos
Copy link
Contributor

hramos commented Aug 16, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Aug 16, 2017
@hramos hramos closed this as completed Aug 16, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Aug 16, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants