Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket issue #15036

Closed
sm2017 opened this issue Jul 16, 2017 · 2 comments
Closed

Websocket issue #15036

sm2017 opened this issue Jul 16, 2017 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@sm2017
Copy link
Contributor

sm2017 commented Jul 16, 2017

I have issue with this line
https://github.com/facebook/react-native/blob/master/Libraries/WebSocket/WebSocket.js#L158

Why when ev.type === 'binary' you consider data as base64? Currently I have issue with android (There is no issue in ios with same message from server)

https://github.com/beatgammit/base64-js/blob/master/index.js#L23 throw this error Invalid string. Length must be a multiple of 4

@sm2017
Copy link
Contributor Author

sm2017 commented Jul 17, 2017

I send #15046 but why base64 encode/decode is required? it is big overhead

@hramos
Copy link
Contributor

hramos commented Jul 17, 2017

Hey, thanks for reporting this issue!

It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

@hramos hramos closed this as completed Jul 17, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 17, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants