Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.0-rc StatusBarIOS.Style.lightContent undefined is not an object #1530

Closed
ldesplat opened this issue Jun 6, 2015 · 4 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ldesplat
Copy link

ldesplat commented Jun 6, 2015

What happened to StatusBarIOS? This used to work on 0.4.x and then I upgraded to 0.5 and it continued working. I then upgraded to 0.6.0-rc and I get undefined is not an object (evaulating 'StatusBarIOS.Style.lightContent').

Inspecting StatusBarIOS I see there is still setStyle and setHidden but that's it.

Alright, going through the docs I see that the API has changed (which is a breaking change). Now we have to put an actual string in so:
StatusBarIOS.setStyle(StatusBarIOS.Style.lightContent, false);
to
StatusBarIOS.setStyle('light-content', false);

@ide
Copy link
Contributor

ide commented Jun 6, 2015

I believe this was an intentional change in 45d8fb0. @nicklockwood could you confirm that the enum was dropped in favor of "default" and "light-content"?

cc @vjeux for the breaking change for the release notes.

@nicklockwood
Copy link
Contributor

Yes, sorry, I updated the example but forgot to include it in the release notes.

@ide
Copy link
Contributor

ide commented Jun 6, 2015

Thanks for confirming.

@ldesplat looks like this is working as intended and thanks for testing the RC!

@ide ide closed this as completed Jun 6, 2015
@vjeux
Copy link
Contributor

vjeux commented Jun 6, 2015

@ide, i'm not at a computer, mind editing the changelog with this and react-native-mixin require (even though I thought that diff was reverted)

@facebook facebook locked as resolved and limited conversation to collaborators Jun 6, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants