Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample project] shouldn't gitignore project.xcworkspace #1560

Closed
itsananderson opened this issue Jun 8, 2015 · 4 comments
Closed

[Sample project] shouldn't gitignore project.xcworkspace #1560

itsananderson opened this issue Jun 8, 2015 · 4 comments
Assignees
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@itsananderson
Copy link

See discussion in #463 where @ide explained why just xcuserdata should be ignored, rather than all of project.xcworkspace.

In this commit: 9b513ed, project.xcworkspace was added to the .gitignore, as well as the sample project's _gitignore file.

One place where this is causing issues is Visual Studio Online, which requires an xcworkspace file to configure automated builds. If I understand correctly, the CocoaSpec project also recommends opening the project.xcworkspace instead of the xcodeproj, so it seems like that would also cause issues.

The workaround here is pretty easy... just remove the project.xcworkspace line from the .gitignore after running react-native init, but would it be a better default to not ignore project.xcworkspace?

@ide
Copy link
Contributor

ide commented Jun 8, 2015

I think it should be fine but may clash with fb's internal workflow (I'm not sure if this is indeed the case -- just a potential issue) cc @frantic

@brentvatne brentvatne changed the title Sample project shouldn't gitignore project.xcworkspace [Sample project] shouldn't gitignore project.xcworkspace Jun 11, 2015
@browniefed
Copy link
Contributor

@brentvatne seems like this can be closed, seems user land fix is easiest. Or maybe it's a react-native init option.

@brentvatne
Copy link
Collaborator

@browniefed - let's leave this open a bit longer to see what @frantic thinks :)

@mkonicek
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/sample-project-shouldnt-gitignore-projectxcworkspace

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.

Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bugfixes as the core team is focused on performance.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants