Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridge] requireNativeComponent should not require native props #1574

Closed
jwyld opened this issue Jun 9, 2015 · 1 comment
Closed

[Bridge] requireNativeComponent should not require native props #1574

jwyld opened this issue Jun 9, 2015 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jwyld
Copy link
Contributor

jwyld commented Jun 9, 2015

It would be possible to provide a native UI element which has no exposed properties. I don't know how often this occurs in practice, but it certainly happened while I was first creating and exposing my native view. requireNativeComponent.js:45 verifies there are native props being exported. If there are none, it slips the UnimplementedView into place.

@brentvatne brentvatne changed the title requireNativeComponent should not require native props [Bridge] requireNativeComponent should not require native props Jun 11, 2015
@brentvatne
Copy link
Collaborator

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out it's new home: https://productpains.com/post/react-native/bridge-requirenativecomponent-should-not-require-native-props

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants