Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'LANG' environment variable needs to be unset to link react-native-fbsdk #16033

Closed
jandom opened this issue Sep 20, 2017 · 2 comments
Closed
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@jandom
Copy link

jandom commented Sep 20, 2017

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Nope

Environment

$ react-native info
Scanning 615 folders for symlinks in /private/tmp/helloWorldApp/node_modules (6ms)

Environment:
  OS:  macOS Sierra 10.12.6
  Node:  8.5.0
  Yarn:  1.0.1
  npm:  5.4.2
  Watchman:  4.9.0
  Xcode:  Xcode 8.3.3 Build version 8E3004b
  Android Studio:  2.3 AI-162.3871768

Packages: (wanted => installed)
  react: 16.0.0-alpha.12 => 16.0.0-alpha.12
  react-native: 0.48.3 => 0.48.3

Steps to Reproduce

$ react-native -v
react-native-cli: 2.0.1
$ react-native init helloWorldApp 
$ cd helloWorldApp
$ react-native info 
react-native install react-native-fbsdk

Expected Behavior

I would expect that it would install without barfing?

Actual Behavior

Scanning 615 folders for symlinks in /private/tmp/helloWorldApp/node_modules (5ms)
yarn add v1.0.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "babel-jest@21.0.2" has incorrect peer dependency "babel-core@^6.0.0 || ^7.0.0-alpha || ^7.0.0-beta || ^7.0.0".
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ react-native-fbsdk@0.6.1
✨  Done in 3.25s.
Scanning 616 folders for symlinks in /private/tmp/helloWorldApp/node_modules (6ms)
rnpm-install info Linking react-native-fbsdk android dependency 
rnpm-install info Android module react-native-fbsdk has been successfully linked 
rnpm-install info Linking react-native-fbsdk ios dependency 
rnpm-install ERR! Something went wrong while linking. Error: Expected "/*", "//", or "{" but "<" found. 
Please file an issue here: https://github.com/facebook/react-native/issues 

Expected "/*", "//", or "{" but "<" found.

Reproducible Demo

See above , this can be fixed by doing

$ LANG= react-native install react-native-fbsdk
Scanning 616 folders for symlinks in /private/tmp/helloWorldApp/node_modules (5ms)
yarn add v1.0.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "babel-jest@21.0.2" has incorrect peer dependency "babel-core@^6.0.0 || ^7.0.0-alpha || ^7.0.0-beta || ^7.0.0".
[4/4] 📃  Building fresh packages...
success Saved 1 new dependency.
└─ react-native-fbsdk@0.6.1
✨  Done in 3.27s.
Scanning 616 folders for symlinks in /private/tmp/helloWorldApp/node_modules (5ms)
rnpm-install info Android module react-native-fbsdk is already linked 
rnpm-install info Linking react-native-fbsdk ios dependency 
rnpm-install info iOS module react-native-fbsdk has been successfully linked 
rnpm-install info Module react-native-fbsdk has been successfully installed & linked 

And then install correctly

$ env 
...
LANG=en_US.UTF-8
...
@jandom jandom changed the title LANG= flag in 'react-native' needed link to get react-native-fbsdk 'LANG' environment variable needs to be unset to link react-native-fbsdk Sep 20, 2017
@aforty
Copy link
Contributor

aforty commented Sep 25, 2017

This is a well known problem with react-native-fbsdk and doesn't really belong here. Submit the problem to Facebook via https://developers.facebook.com/bugs instead.

@stale
Copy link

stale bot commented Nov 24, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 24, 2017
@stale stale bot closed this as completed Dec 1, 2017
@facebook facebook locked and limited conversation to collaborators May 15, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants