Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTLocationObserver accuracy reset bug? #17145

Closed
sakarit-zz opened this issue Dec 11, 2017 · 2 comments
Closed

RCTLocationObserver accuracy reset bug? #17145

sakarit-zz opened this issue Dec 11, 2017 · 2 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@sakarit-zz
Copy link

_locationManager.desiredAccuracy = RCT_DEFAULT_LOCATION_ACCURACY;

Is there a bug here? I don't understand why the desiredAccuracy should be reset to DEFAULT if enableHighAccuracy is enabled and the desiredAccuracy is initially kCLLocationAccuracyBest.

Also I think this should be added to beginLocationUpdatesWithDesiredAccuracy

_locationManager.pausesLocationUpdatesAutomatically = NO;

so location updates would not pause when using watchPosition

@react-native-bot
Copy link
Collaborator

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Hey @sakarit, thanks for posting this! It looks like your issue is missing some required information. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce your issue. I am going to close this, but please feel free to open a new issue with the additional information provided. Thanks!

How to ContributeWhat to Expect from Maintainers

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Dec 11, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Dec 11, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants