Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIP_BUNDLING does not take dev-machine IP into account #17301

Closed
Knight704 opened this issue Dec 21, 2017 · 2 comments
Closed

SKIP_BUNDLING does not take dev-machine IP into account #17301

Knight704 opened this issue Dec 21, 2017 · 2 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@Knight704
Copy link

Is this a bug report?

yes

Have you read the Contributing Guidelines?

yes

Environment

OS: macOS Sierra 10.12.6
Node: 9.0.0
Yarn: 0.24.6
npm: 5.5.1
Watchman: 4.9.0
Xcode: Xcode 9.1 Build version 9B55
Android Studio: 2.3 AI-162.3934792

Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: 0.48.4 => 0.48.4

Steps to Reproduce

  1. Run SKIP_BUNDLING=true react-native run-ios --device
  2. Wait app build and install on device
  3. Open app

Expected Behavior

App loads bundle from local packager

Actual Behavior

App uses bundled file, doesn't download from packager

@Knight704 Knight704 changed the title SKIP_BUNDLING does not take into account IP SKIP_BUNDLING does not take dev-machine IP into account Dec 21, 2017
@rmevans9
Copy link
Contributor

#16533 seems like it will fix this.

@stale
Copy link

stale bot commented Feb 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 20, 2018
@stale stale bot closed this as completed Feb 27, 2018
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants