[RN 0.52] RCTImageLoader requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup

[fungilation]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
  OS: macOS Sierra 10.12.6
  Node: 9.3.0
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: Not Found

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.52.0 => 0.52.0

Steps to Reproduce

$ react-native run-ios

Expected Behavior

iOS simulator run without errors.

Actual Behavior

^

Module RCTImageLoader requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Reproducible Demo

Any app using the Image component, although in my app I wrap that in a higher level component I use: react-native-fit-image.

I've never seen RCTImageLoader complain about requiresMainQueueSetup before. Only started now after I upgraded RN from 0.51 to 0.52.

[shettayyy]

For me, it doesn't show any warning in the simulator but appears as a warning in the browser console.

RN Version: 0.53.3
React Version: 16.2.0

[hramos]

PR #17679 is an attempt to fix this.

[animaonline]

Started getting this in 0.54.0, is there a way to actually disable the warning?

This doesn't seem to work:

YellowBox.ignoreWarnings([
'Warning: Module RCTImageLoader requires',
]);

[fungilation]

because the warning has no "warning: " prefix. Take that out in your ignore

[alzalabany]

can we merge this soon ?

[hramos]

Merged

[fungilation]

It'll be included in RN 0.56 I take it?

[iRoachie]

It should be in the next minor (0.56.0), the patch updates(x.x.patch) only fix errors found in the latest minor afaik.

[iRoachie]

It’s merged into master but it’s not released in a version as yet

[watadarkstar]

Thanks for the quick reply @iRoachie !

[iRoachie]

There has been no major release as yet guys. Please stop saying it’s still showing. @hramos can you lock this thread ?

[hramos]

Fix is in master. You may build React Native from source to take advantage of the fix.