Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earlier versioned documentation Guides serve latest documentation #18232

Closed
atticoos opened this issue Mar 6, 2018 · 2 comments
Closed

Earlier versioned documentation Guides serve latest documentation #18232

atticoos opened this issue Mar 6, 2018 · 2 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@atticoos
Copy link
Contributor

atticoos commented Mar 6, 2018

Earlier versions of documentation for earlier React Native distributions can be accessed via https://facebook.github.io/react-native/versions.html

After documentation site redesign, it looks like the Guides documentation is serving the latest version, even if you're browsing an earlier version.

For example, take 0.27, this dates back to June 2016.

Viewing the Animations Guide documentation, https://facebook.github.io/react-native/docs/0.27/animations.html, it links to content that didn't exist in 2016, such as this 2017blog post: http://facebook.github.io/react-native/blog/2017/02/14/using-native-driver-for-animated.html

These guides still exist in their original form in https://github.com/facebook/react-native/tree/0.27-stable/docs. Can we serve earlier version's corresponding Guides?


Component/Module API documentation is serving as expected. Example:

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like your issue may be incomplete. Are all the fields required by the Issue Template filled out?

You may safely ignore this if you believe your issue contains all the relevant information. Thank you for your contributions.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added No Template Ran Commands One of our bots successfully processed a command. labels Mar 6, 2018
@hramos
Copy link
Contributor

hramos commented Mar 8, 2018

This is intentional. Guides are considered "unversioned", save for a few exceptions (CocoaPods instructions varied across a few recent versions).

Closing as documentation issues are tracked in github.com/facebook/react-native-website these days.

@hramos hramos closed this as completed Mar 8, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Mar 8, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants