Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when will this branch be hit? #18270

Closed
fatfatson opened this issue Mar 8, 2018 · 2 comments
Closed

when will this branch be hit? #18270

fatfatson opened this issue Mar 8, 2018 · 2 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@fatfatson
Copy link

mCreateReactContextThread is assigned in runCreateReactContextOnNewThread in UI-thread,which is called in recreateReactContextInBackground also in UI-thread, there's no opportunity another call to recreateReactContextInBackground be performed before the current one return,

so it seems there's no need to have this check and set a mPendingReactContextInitParams for re-enter protection?

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like your issue may be incomplete. Are all the fields required by the Issue Template filled out?

You may safely ignore this if you believe your issue contains all the relevant information. Thank you for your contributions.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added No Template Ran Commands One of our bots successfully processed a command. labels Mar 8, 2018
@react-native-bot
Copy link
Collaborator

This issue was marked as lacking information required by the issue template. There has been no activity on this issue for a while, so I will go ahead and close it.

If you found this thread after encountering the same issue in the latest release, please feel free to create a new issue with up-to-date information by clicking here.

If you are the author of this issue and you believe this issue was closed in error (i.e. you have edited your issue to ensure it meets the template requirements), please let us know.

@facebook facebook locked as resolved and limited conversation to collaborators Mar 16, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants