-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatlist not supported for RTL #19150
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
not fixed on RN 0.57 |
still experiencing this error (RN 0.55.4). If the list data / content doesn't update, it works fine. Using legacyImplementation={true} helps. But you can't use scrollTo, onViewableItemsChanged or other interactive functions, because it will generate errors. Can someone look into this issue, please? |
@DanGDroid let me know if there's a pull request we can take a look at. |
This comment has been minimized.
This comment has been minimized.
no solution but to do it your own, i implemented a lazy loader of ScrollView but does not have all the benefits of a virtualised list |
What about |
@sahrens I tried now, it's not working. it's still from left to right. |
any update on this ?? still facing this only in RTL react-native version 0.57.3 |
is there any plan to fix the horizontal flatlist for RTL ? |
We have an internal task tracking this: T42861459 |
@sahrens would please let me know what is the status of this internal task is there going to be any solution soon ? |
While we are tracking this internally, this issue is still up for grabs. If anyone from the community is interested in providing a pull request, please go ahead. |
Before this issue is resolved a quick workaround for now is to set |
anyone found a solution to this yet ? as @sammy-SC said i tried initialNumToRender but it causes huge performance issues with a large list |
Hello there, |
Thank you for your kind suggestion however there are a few things wrong with it.
This issue is old and the problem described here doesn't happen anymore a new problem occurs on the 0.68 or sdk 45 for expo Maybe it's better to close this and move there? @DanGDroid |
And could you please also inform us about the state of that task and if you have considered the new issue? #34314 |
Any updates on this internal issue? @cortinico These kind of RTL issues in react native cause too much problem developing RTL applications and I have dealt with it for many years. Some issues I have faced:
|
These are all true but most of them are fixable with workaround the recent bug on the latest version though has no workarounds that's a terrible bug have you noticed it too? On 0.68, just on start it will have a wrong scroll position and when you scroll far away it gets back that initial wrong position, this is like a major issue with no workarounds right now. Btw: |
I have been experiencing this since I started working with rn 6 years ago 😅 |
On expo sdk 44, everything was almost fine with flatlist there was one slight issue only which could be fixed via a workaround. The issue I'm mentioning happened quite recently though. |
I'm currently working on switching |
Hi guys, recyclerlistview is working great for me - using it with
and with RTL language (Hebrew) on Android, and not having any issues. Cheers. |
Thank you for reporting back, so you only applied that patch? Isn't it more convenient for you to use flashlist from Shopify it works with recyclereview internally but provides a syntax same as FlatList. That would make the migration of existing apps also easier. I applied the patch of that PR Shopify/flash-list#544 (comment) and all yet couldn't get it working yet, didn't use the pagingEnabled though was that mandatory? |
I only had to apply the patch Flipkart/recyclerlistview#629 on the latest version of
I considered flash-list but it has fewer GitHub stars than recyclerlistview. |
add But have anther issue |
FlashList has some other issues with RTL, see Shopify/flash-list#544 and Shopify/flash-list#620. Recyclerlistview with this patch Flipkart/recyclerlistview#629 is the best solution at the moment |
Hello, I created solution for this bug, not perfect but almost working.
This code allow to use horizontal list in RTL app , but when we have paggination enabled after scroll and new page was added then list jump to last itemIndex % maxToRenderPerBatch Code is not perfect, after 5 years of inactivity from Facebook side I think |
Thanks for sharing, seriously what is wrong with Facebook, it's not like they don't have rtl apps themselves do yourself a favor at least |
in 2023 ''m found good solution ----> move to flutter |
Thank you finally something about this. One huge problem with the current flatlist of react native is that when you scroll it scrolls back it starts at the middle also instead of beginning you scroll forward like go more than 10 items it suddenly scrolls back to the 5th items and so on. Can you verify this problem doesn't exist with your package? Also I checked you have android and ios folder in your github but in your readme's installation only mention |
I'm sorry, my solution fixing margin when change language with LTR systems, so it's not solving these issues. |
#37651 |
Issue Still Exists in React Native 0.70.10 , Any working solutions , Please let us know . |
Still open |
issue still exists |
This issue is fixed in RN 0.73. |
I have released a new library where I attempted to address this issue. Please check it out. |
In your library, where did you implement the scroll ref? |
The solution for the Android RTL is to use scrollToIndex instead of scrollToOffset
|
I see that you did custom RTL horizontal list view by ScrollView. It wrong in the began |
<Flatlist> horizontal true
component does not work properly on Rtl devices, it renders the items again and jumps to head of list. impossible to useEnvironment
Environment:
OS: macOS High Sierra 10.13.4
Node: 8.2.1
Yarn: 1.3.2
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.1 AI-173.4670197
Packages: (wanted => installed)
react: 16.3.2 => 16.3.2
react-native: 0.55.0 => 0.55.0
Steps to Reproduce
Expected Behavior
<Flat list should adopt to relevant direction as
I18nManager.isRtl` returnsActual Behavior
<Flatlist> horizontal true
component does not work properly on Rtl devices, it renders the items again and jumps to head of list. impossible to useif i add attribute
legacyImplementation={true}
it works fine but as said in documents i doent know what traits of Flatlist i loose.The text was updated successfully, but these errors were encountered: