Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to react native 0.56 requires updating you ProGuard config to fix Fresco #20604

Closed
luisnaranjo733 opened this issue Aug 9, 2018 · 3 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@luisnaranjo733
Copy link

I migrated from 0.55.4 to 0.56.0 and now ProGuard is failing my Android build. I think Fresco is getting one of its dependencies eliminated by ProGuard, so we need to write a keep line to prevent this. It would be nice to add this to the changelog of 0.56. Or alternatively, should react-native-upgrade do this automatically? I looked at your proguard template files, and they don't seem to have any lines that would fix this. I guess this may have just slipped under the radar.

10:16:29.581 [ERROR] [system.err] Warning: com.facebook.imagepipeline.nativecode.StaticWebpNativeLoader: can't find referenced class com.facebook.common.soloader.SoLoaderShim
10:16:29.581 [ERROR] [system.err] Warning: com.facebook.imagepipeline.nativecode.StaticWebpNativeLoader: can't find referenced class com.facebook.common.soloader.SoLoaderShim
10:16:31.897 [ERROR] [system.err] Warning: there were 2 unresolved references to classes or interfaces.

@luisnaranjo733
Copy link
Author

Worth noting I'm on implementation 'com.facebook.fresco:webpsupport:1.30'.

Checking what happens if I migrate to 10 now

@luisnaranjo733
Copy link
Author

Also I created a dupe that probably lives in a more appropriate place
facebook/fresco#2181

@react-native-bot
Copy link
Collaborator

We are automatically closing this issue because it does not appear to follow any of the provided issue templates.

Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library.

If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. 📋No Template labels Aug 9, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Aug 9, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants