Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport Height not 100%. #20970

Closed
kevupton opened this issue Sep 4, 2018 · 4 comments
Closed

Viewport Height not 100%. #20970

kevupton opened this issue Sep 4, 2018 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@kevupton
Copy link

kevupton commented Sep 4, 2018

Environment

React Native Environment Info:
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
Memory: 12.50 GB / 31.92 GB
Binaries:
Yarn: 1.9.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 5.6.0 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version 3.1.0.0 AI-173.4819257

Description

Describe your issue in detail. Include screenshots if needed. If this is a regression, let us know.

spacing-issue

As you can see in this image, there seems to be double the bottom spacing. Or the app is not at 100% height.

This is only appearing on my phone: Xiaomi 8 on Android Orio 8.1

The spacing appears to be the same height as the menu down the bottom so it seems like it thinks the app is the full screen height.

This spacing is there when the app first loads (so on the splash screen as well.)

I think its to do with the hideable menu, as I have seen apps hide this menu, however I am not aware of how to do this.

Reproducible Demo

This seems to be more of a device specific issue which I have not been able to reproduce on any emulators.

Xiaomi 8 Device

@LasseSLambertsen
Copy link

Update gradle and target sdk 😊
Had same issue on my own Mi8, it will look the same on all 18/9 screens

@kevupton
Copy link
Author

kevupton commented Sep 6, 2018

Thanks @LasseSLambertsen
Does this fix the issue after uprading ?
Any chance your could let me know what versions of gradle and sdk you are using ? ❤️

@markhomoki
Copy link

Thanks @LasseSLambertsen. Upgrading the targetSdkVersion to 26 fixed the issue.

@LasseSLambertsen
Copy link

@markhomoki Good to hear, was not sure which one did the magic 😅

@kevupton Sorry, for never answering, completely forgot about the issue 😔

@facebook facebook locked as resolved and limited conversation to collaborators Sep 25, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants