Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behaviour panResponder inside scrollview on android and ios #21894

Closed
3 tasks done
svenlombaert opened this issue Oct 22, 2018 · 7 comments
Closed
3 tasks done
Labels
API: PanResponder Bug Platform: Android Android applications. Platform: iOS iOS applications. Priority: Mid Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@svenlombaert
Copy link

Environment

  React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
      Memory: 1.53 GB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.12.0 - /usr/local/bin/node
      Yarn: 1.10.1 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
      Android SDK:
        Build Tools: 23.0.1, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3
        API Levels: 23, 25, 26
    IDEs:
      Xcode: 10.0/10A255 - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.5.0 => 16.5.0
      react-native: ^0.57.2 => 0.57.2
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7
      react-native-sensors: 4.0.0
      react-native-store-review: 0.1.5

Description

I've made a simple demo which shows different behaviour between ios and android when using PanResponder on a View inside a ScrollView.

iOS: If I scroll over the red square, the panResponder triggers onPanResponderTerminate, so the ScrollView takes over

Android: If I scroll over the red square, the panResponder triggers onPanResponderMove, so the ScrollView doesn't scroll.

I don't know which one is the right behaviour, but I'd like to reproduce the iOS behaviour for both.

Reproducible Demo

https://snack.expo.io/@svrnlombaert/panresponder-behaviour-on-scroll

Android behaviour:
https://i.imgur.com/UXjajkr.gifv

iOS behaviour:
https://i.imgur.com/4YImWKL.gifv

@stale
Copy link

stale bot commented Jan 20, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 20, 2019
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 24, 2019
@hramos hramos removed the Bug Report label Feb 6, 2019
@kelset
Copy link
Contributor

kelset commented Mar 19, 2019

Hello there 👋 this issue seems to have been inactive for the past few weeks. Because of this, it's likely that the issue is not a high priority anymore or it has been solved by OP; for these reasons, we'll close it. But please, if it's actually still an issue with 0.59 please comment below and we can reopen it or please send us a Pull Request with a fix 😊

@kelset kelset closed this as completed Mar 19, 2019
@svenlombaert
Copy link
Author

I just created an empty 0.59.1 project (using react-native-cli), pasted the code from the snack above, and can confirm, the issue persists.

@ghost
Copy link

ghost commented Jun 9, 2019

I have this too

@kelset
Copy link
Contributor

kelset commented Jun 10, 2019

Can you test it against 0.59.9 and against the 0.60rc? In the last couple patches there were quite a few commits related to ScrollViews

@stale
Copy link

stale bot commented Sep 8, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 8, 2019
@stale
Copy link

stale bot commented Sep 15, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Sep 15, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API: PanResponder Bug Platform: Android Android applications. Platform: iOS iOS applications. Priority: Mid Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

4 participants