-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextInput] Blur event is broken in v0.57.6 #22425
Comments
@gazoudoudou can you check that please? |
Happens only on Android for me (I will label it like that), if anyone can reproduce on iOS please write it here. |
Hey @ahce thanks for the report, since it's a fairly big issue I'll revert that commit and create a new release asap. |
@kelset Shouldn't we fix the underlying issue? It seems wrong that this "double blur" is needed on Android and not on iOS (and that it is needed at all) |
@Minishlink absolutely, the issue should get a proper fix: but that needs to be a PR to master and fix it 'once and for all'. This revert & new release is to simply prevent people from facing it in 0.57.patch - now that we are aware of the fact of that commit being broken, I'll leave this issue open so that we can properly fix it. @ahce let me know if 0.57.7 works fine for you now (I just created a test project and was able to repro, and updating to 0.57.7 fixed this) |
Summary: I noticed that the _onBlur method was not exactly similar to the _onFocus one in the TextInput component. After digging, I found that the blurTextInput method in the TextInputState.js file was call twice in a raw instead of once when the textinput component should blur. By removing this line, I fix this unecessary multiple call. Pull Request resolved: #22156 Reviewed By: TheSavior Differential Revision: D13105396 Pulled By: RSNara fbshipit-source-id: 8e83461d8b288d8ee4047bc4a33c4480e193c349
@kelset works fine in 0.57.7, Thanks! |
FYI, @RSNara has a fix incoming to master. |
Fix is to revert #22156 |
@sahrens so there's no better fix for that? IMO at least on iOS we should not call it twice. |
We're reverting for now to be safe. Could potentially add an iOS check if it's causing problems. |
Closing since this issue has actually being fixed by the revert. |
Environment
Description
The input is not focused after the blur event with the done button.
Blur event was broken with this commit,
Reproducible Demo
The text was updated successfully, but these errors were encountered: