Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce code quality tools for android. #23332

Closed
gengjiawen opened this issue Feb 7, 2019 · 5 comments
Closed

Introduce code quality tools for android. #23332

gengjiawen opened this issue Feb 7, 2019 · 5 comments
Assignees
Labels
Contributor A React Native contributor. Partner Platform: Android Android applications. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@gengjiawen
Copy link
Contributor

With the help of findbugs, PMD, we may find some problem early.

Maybe we can refer to: https://github.com/vanniktech/gradle-code-quality-tools-plugin.

cc @dulmandakh @hramos

@gengjiawen gengjiawen added the Type: Discussion Long running discussion. label Feb 7, 2019
@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. Partner labels Feb 7, 2019
@react-native-bot react-native-bot added the Platform: Android Android applications. label Feb 7, 2019
@dulmandakh
Copy link
Contributor

currently, I'm using https://developer.android.com/studio/write/lint and recent PRs to reduce errors/warnings detected by using lint.

it would be nice to start with very basic setup, and like commit must not increase error/warning count, otherwise CI fails.

@dulmandakh
Copy link
Contributor

I found that there are many places where code just don't work due to use of newer APIs than 16 and crashes. I replaced some code from support library, but still having errors.

@dulmandakh
Copy link
Contributor

another PR with lint error/warning fixes #23333. it's WIP.

@dulmandakh
Copy link
Contributor

Note: ./gradlew :ReactAndroid:lint generates very useful report

@cpojer
Copy link
Contributor

cpojer commented Mar 19, 2019

This issue was a discussion and we agreed that a PR should be sent. @gengjiawen please consider sending a PR with the fix but I'm gonna close the issue because on its own it isn't actionable.

@cpojer cpojer closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contributor A React Native contributor. Partner Platform: Android Android applications. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

7 participants