Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the use of ImageEditor.cropImage #23957

Closed
liangguohun opened this issue Mar 15, 2019 · 3 comments
Closed

about the use of ImageEditor.cropImage #23957

liangguohun opened this issue Mar 15, 2019 · 3 comments

Comments

@liangguohun
Copy link

🐛 Bug Report

To Reproduce

I use the react-native-camera take a photo,
and then i use ImageEditor.cropImage to crop the photo for id card part,
i just set cropData with offset size but ,i always get the target height but the width can't cut off

version: 0.52.0
phone android 9

Expected Behavior

just crop the target Rect .

Code Example

Environment

@react-native-bot
Copy link
Collaborator

Can you run react-native info and edit your issue to include these results under the Environment section?

If you believe this information is irrelevant to the reported issue, you may write `[skip envinfo]` alongside an explanation in your Environment: section.

@liangguohun
Copy link
Author

Environment:
OS: Windows 10
Node: 10.15.0
Yarn: 1.13.0
npm: 6.4.1
Watchman: Not Found
Xcode: N/A
Android Studio: Version 2.3.0.0 AI-162.4069837

Packages: (wanted => installed)
react: ^16.2.0 => 16.8.3
react-native: ^0.52.0 => 0.52.3

i have got it, is the react-native-camera make the image portrait and landscape different every time, and config with orientation:RNCamera.Constants.Orientation.portrait.
but still have a question is that the crop is use int size ,but my React nedd indeed is float , the bound will not well

@bartolkaruza
Copy link

Hi @liangguohun, thanks for reporting this issue. I'm closing it as you seem to have resolved your initial problem/question. You remaining question looks more suited for Stackoverflow, but let me know if I interpreted it wrong.

@facebook facebook locked as resolved and limited conversation to collaborators Mar 20, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants